fix(tags): Edit tags icon fontawesome url to v5 #3965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davwheat
approved these changes
Feb 21, 2024
askvortsov1
approved these changes
Apr 5, 2024
|
Although this PR makes a lot of sense, I think we need to aim to include FA 6 with 2.x. And this link, with the PR targeting 2.x, would as such then be incorrect. Maybe this change is best made to My apologies for the nitpick @dian-kaagman ; je bijdrage is alsnog erg gewaardeerd 👍 |
|
Thank you for the PR and sorry for the delayed response! 2.x now supports FA v6 #4020. But the link could still use updating though to: https://fontawesome.com/search?o=r&m=free so that the page is actually the search for free icons one. @dian-kaagman would you like to make that change? |
|
Implemented via #4038, closing this, but thank you for your efforts here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000 (no issue)
Changes proposed in this pull request:
The Fontawesome url referred to the newest icons overview, since the tags extension only supports v5 icons it's confusing for admin users why some icons don't work. The url for supported icons is: https://fontawesome.com/v5/icons?m=free.
Reviewers should focus on:
Screenshot
QA
Necessity
Confirmed
composer test).